Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7730: gh data sourcing and screenshot generation #8320

Merged
merged 19 commits into from
Sep 28, 2018
Merged

7730: gh data sourcing and screenshot generation #8320

merged 19 commits into from
Sep 28, 2018

Conversation

amberleyromo
Copy link
Contributor

@amberleyromo amberleyromo commented Sep 19, 2018 •
edited
Loading

(not ready for merge) ready for review

Closes #7730

tldr; this moves the data sourcing and creation of the starter showcase landing page and starter pages in line with the other data sourcing (eg site showcase).

todos:

  • pull starter data from yml (in sync with site showcase flow)
  • update gatsby-transformer-screenshot to target add'l node types
  • update gatsby-transformer-screenshot to not break everything on failed max retries
  • convert all view code to reference yml data + new child screenshots instead of markdown/screenshot file
  • remove hanging references to old starter data
  • handle gh token for prod
  • ensure lacking a gh token in dev mode doesn't break www DX
  • what is this wat commit? lol (dropped)

@amberleyromo amberleyromo force-pushed the 7730-starter-showcase-sourcing branch from 710e803 to f1d386a Compare September 19, 2018 22:30
jlengstorf
jlengstorf previously requested changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! No real feedback other than the changes you called out already.

www/README.md Show resolved Hide resolved
www/gatsby-node.js Outdated Show resolved Hide resolved
www/gatsby-node.js Outdated Show resolved Hide resolved
www/src/views/starter-showcase/filtered-showcase.js Outdated Show resolved Hide resolved
www/src/views/starter-showcase/filtered-showcase.js Outdated Show resolved Hide resolved
www/src/views/starter-showcase/showcase-list.js Outdated Show resolved Hide resolved
@fk fk mentioned this pull request Sep 21, 2018
Merged
@amberleyromo amberleyromo mentioned this pull request Sep 24, 2018
Merged
@amberleyromo amberleyromo force-pushed the 7730-starter-showcase-sourcing branch from c2563fb to 6611f69 Compare September 24, 2018 17:45
jlengstorf
jlengstorf approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s get this in!

This was referenced Sep 24, 2018
Closed
Merged
jlengstorf pushed a commit that referenced this pull request Sep 26, 2018
fix: add ecosystem team for starters YAML
24ad2e5 
This file doesn’t exist on `master` yet, but it will once @amberleyromo’s PR #8320 gets merged.
This was referenced Sep 28, 2018
Merged
Merged
@amberleyromo amberleyromo requested a review from a team September 28, 2018 15:41
@amberleyromo amberleyromo requested a review from a team as a code owner September 28, 2018 15:41
@amberleyromo
(gatsbyjs#7730): add starters.yml
c541da0
@amberleyromo
(gatsbyjs#7730): Re-form and move github metadata sourcing, add dotenv
99e459a
@amberleyromo
(gatsbyjs#7730): Change data in view to draw appropriately from start…
0ac11cb 
…er yml
@amberleyromo
(gatsbyjs#7730): create starter pages referencing yaml
8f8e6ba
@amberleyromo
(gatsbyjs#7730): Convert starter data in view from markdown to yml
2691d2d
@amberleyromo
(gatsbyjs#7730): Rm references to old starter data
e5e159d
@amberleyromo
(gatsbyjs#7730): Delete old static starter showcase data
dbc8beb
@amberleyromo
(gatsbyjs#7730): Update broken starter demo link
9e5dbae
@amberleyromo
(gatsbyjs#7730): Remove hanging references to deleted data
ff42a7b
@amberleyromo
(gatsbyjs#7730): Prioritize stars for v1
cce0460
@amberleyromo
(gatsbyjs#7730): Manage DX if gh token not supplied for starter data …
52ef880 
…sourcing; break on build
@amberleyromo
(gatsbyjs#7730): Change how owner and repo are parsed from GitHub url…
a372995 
…; Rm UI messaging if gh data empty
@amberleyromo
(gatsbyjs#7730): Code formatting tweak
0916cfa
@amberleyromo amberleyromo force-pushed the 7730-starter-showcase-sourcing branch from de5e37b to 43bcf66 Compare September 28, 2018 16:03
fk
fk approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jlengstorf jlengstorf merged commit 1ae7568 into gatsbyjs:master Sep 28, 2018
lipis added a commit to lipis/gatsby that referenced this pull request Sep 28, 2018
@lipis
Merge branch 'master' of github.com:gatsbyjs/gatsby into hooks
66606b0 
* 'master' of github.com:gatsbyjs/gatsby:
  feat(starter showcase): gh data sourcing and screenshot generation (gatsbyjs#8320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickyMeuleman NickyMeuleman NickyMeuleman left review comments

@jlengstorf jlengstorf jlengstorf approved these changes

@fk fk fk approved these changes

@kkemple kkemple Awaiting requested review from kkemple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amberleyromo @fk @jlengstorf @NickyMeuleman