Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX v2: Support FS routes #36118

Merged
merged 11 commits into from
Jul 25, 2022
Merged

MDX v2: Support FS routes #36118

merged 11 commits into from
Jul 25, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jul 13, 2022

Description

Adds ?__contentFilePath= to createPage action inside FS routes. This is achieved through accessing node.internal.contentFilePath in gatsby-plugin-page-creator.

So the page creator is "dumb"/independent of MDX and just looks for this generic API "contentFilePath" and the MDX plugin implements it by adding it to node.internal

[ch52913]

@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: remark/mdx Related to Markdown, remark & MDX ecosystem labels Jul 13, 2022
@LekoArts LekoArts added this to the MDX v2 milestone Jul 13, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 13, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 13, 2022
@LekoArts LekoArts merged commit f262e97 into feat/mdx-v2 Jul 25, 2022
@LekoArts LekoArts deleted the mdx-v2-fs-api branch July 25, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant