-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(gatsby-plugin-mdx): MDX v2 #35650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 13, 2022
axe312ger
commented
May 13, 2022
axe312ger
force-pushed
the
feat/mdx-v2
branch
2 times, most recently
from
May 13, 2022 13:50
e0b26c8
to
cb0bf76
Compare
Khaledgarbaya
added
the
topic: remark/mdx
Related to Markdown, remark & MDX ecosystem
label
May 16, 2022
imjoshin
reviewed
May 16, 2022
LekoArts
added
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
May 17, 2022
2 tasks
LekoArts
reviewed
Jun 4, 2022
jxnblk
reviewed
Jun 17, 2022
1 task
I'm so excited about this! Great work @axe312ger 👏 👏 |
Co-authored-by: Josh Johnson <[email protected]>
This was referenced Dec 26, 2022
1 task
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: remark/mdx
Related to Markdown, remark & MDX ecosystem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
gatsby-plugin-mdx
with a new version that is powered by MDX v2.We won't be 100% backwards compatible, but most use cases will be covered. Simplification and better performance is the overall goal.
Separate PRs
Changes:
This is a complete rewrite of the plugin, so some old features might be gone.
New features
MDXRenderer
is no more needed.mdxOptions
config option you can pass any configuration to@mdx-js/js
compile likeremarkPlugins
,rehypePlugins
,recmaPlugins
and more.Kept features
.mdx
files fromsrc/pages
are turned into real pages.mdx
files loaded viagatsby-source-filesystem
or as component viacreatePage
can be turned into real pagesgatsby-remark-*
plugins mdx-v2: feat: add support for remark, rehype and gatsby-remark plugins #35751Removed features
defaultLayouts
is gonelessBabel
is gonemediaTypes
is goneshouldBlockNodeFromTransformation
is gonePost Release ToDos
Closes #25068
Closes #34421
Closes #35733
Closes #35732