Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): migrate query/redirectWriter to TypeScript #23785

Closed

Conversation

taejs
Copy link
Contributor

@taejs taejs commented May 5, 2020

Description

Migrate query/redirectWriter to TypeScript

Related Issues

Related to #21995

@taejs taejs requested a review from a team as a code owner May 5, 2020 12:53
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2020
const debouncedWriteRedirects = _.debounce(() => {
// Don't write redirects again until bootstrap has finished.
if (
bootstrapFinished &&
!_.isEqual(oldRedirects, store.getState().redirects)
) {
writeRedirects()
oldRedirects = store.getState().Redirects
oldRedirects = store.getState().redirects
Copy link
Contributor Author

@taejs taejs May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected this code because I think it's a typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice catch!

But there is some asterisk regarding this entire file - we actually don't use it anywhere 😱

It seems after we moved this file to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/bootstrap/redirects-writer.js there was some git messup and old file location stayed. What's really weird is that the file we actually use - don't even have that check

@pieh
Copy link
Contributor

pieh commented May 5, 2020

Hey @taejs!

This seems to be duplicate of #23332. I'm just looking, at that was not tracked in typescript migration umbrella issue - so sorry about that. Given that you are already member of gatsby org because of previous pull requests I would like to give a chance to other PR as this is author's first if that's fine with you?

@taejs
Copy link
Contributor Author

taejs commented May 5, 2020

Sure! no problem

@taejs taejs closed this May 5, 2020
@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants