-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): Migrate query/redirects-writer to Typescript #23332
Conversation
0a77e86
to
777fa4a
Compare
Hey @PerfectPan! First of all thanks for submitting PR. I will fix-up type problem (cause by some type that showed up after we add types in other parts of the code) and will merge your PR as you did work we asked for in Typescript umbrella issue. Unfortunately I will have to later on delete the entire file because we are actually not using it anywhere because in the past we moved it to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/bootstrap/redirects-writer.ts and there must have been some git issue related to move that we didn't caught and ended up with 2 copies of same file. We do appreciate effort you put into this change and as I mentioned we will merge the PR - I'm just letting you know that unfortunately it proved unneeded :( That's on us - very sorry about this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PerfectPan!
Holy buckets, @PerfectPan — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
That's OK! I will try to work on other files. Thanks a lot! @pieh |
Description
Migrates redirects-writer(
gatsby/src/query/redirects-writer.js
) to TypescriptRelated Issues
Related to #21995