Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Migrate query/redirects-writer to Typescript #23332

Merged
merged 3 commits into from
May 5, 2020

Conversation

PerfectPan
Copy link
Contributor

@PerfectPan PerfectPan commented Apr 21, 2020

Description

Migrates redirects-writer(gatsby/src/query/redirects-writer.js) to Typescript

Related Issues

Related to #21995

@pieh
Copy link
Contributor

pieh commented May 5, 2020

Hey @PerfectPan!

First of all thanks for submitting PR. I will fix-up type problem (cause by some type that showed up after we add types in other parts of the code) and will merge your PR as you did work we asked for in Typescript umbrella issue. Unfortunately I will have to later on delete the entire file because we are actually not using it anywhere because in the past we moved it to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/bootstrap/redirects-writer.ts and there must have been some git issue related to move that we didn't caught and ended up with 2 copies of same file. We do appreciate effort you put into this change and as I mentioned we will merge the PR - I'm just letting you know that unfortunately it proved unneeded :( That's on us - very sorry about this

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PerfectPan!

@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 5, 2020
@gatsbybot gatsbybot merged commit 56f91a5 into gatsbyjs:master May 5, 2020
@gatsbot
Copy link

gatsbot bot commented May 5, 2020

Holy buckets, @PerfectPan — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@PerfectPan
Copy link
Contributor Author

That's OK! I will try to work on other files. Thanks a lot! @pieh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants