fix(gatsby): use history fallback to display client-only routes in serve #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As best as I can tell--this fixes a few issues identified with client-only routes, without causing a regression in existing functionality. What I validated: - Client only routes work (and work on initial navigation, e.g. given dynamic path /app/1234, it works when navigated to and on initial route) - Existing routes created via SSR work - 404 routes work (and direct 404.html route) Fixes gatsbyjs#8080
KyleAMathews
approved these changes
Feb 6, 2019
|
Checking out the failing production runtime test! |
|
The tests pass locally - must be some CI weirdness :/ I'll check this out in a bit, and try to fix the flaky gatsby-image test too. |
DSchau
added a commit
to DSchau/gatsby
that referenced
this pull request
Feb 6, 2019
…es in serve (gatsbyjs#11581)" This reverts commit 75f6118.
DSchau
added a commit
to DSchau/gatsby
that referenced
this pull request
Feb 7, 2019
…es in serve (gatsbyjs#11581)" This reverts commit 75f6118.
wardpeet
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Revert "fix(gatsby): use history fallback to display client-only routes in serve (#11581)" This reverts commit 75f6118. * Revert "fix(gatsby): use history fallback to display client-only routes in serve (#11581)" This reverts commit 75f6118. * fix: use smart history fallback that understands gatsby matchPath * chore: fix * refactor: swap to reach router instead of micromatch * chore: move check up * chore: tweak name
gurpreet-hanjra
pushed a commit
to gurpreet-hanjra/gatsby
that referenced
this pull request
Feb 14, 2019
) * Revert "fix(gatsby): use history fallback to display client-only routes in serve (gatsbyjs#11581)" This reverts commit 75f6118. * Revert "fix(gatsby): use history fallback to display client-only routes in serve (gatsbyjs#11581)" This reverts commit 75f6118. * fix: use smart history fallback that understands gatsby matchPath * chore: fix * refactor: swap to reach router instead of micromatch * chore: move check up * chore: tweak name
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
) * Revert "fix(gatsby): use history fallback to display client-only routes in serve (gatsbyjs#11581)" This reverts commit 75f6118. * Revert "fix(gatsby): use history fallback to display client-only routes in serve (gatsbyjs#11581)" This reverts commit 75f6118. * fix: use smart history fallback that understands gatsby matchPath * chore: fix * refactor: swap to reach router instead of micromatch * chore: move check up * chore: tweak name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As best as I can tell--this fixes a few issues identified with
client-only routes, without causing a regression in existing
functionality.
What I validated:
dynamic path /app/1234, it works when navigated to and on initial route)
/asdfasdfasdfloads 404 page/404loads 404 pagecc @jquense
Related Issues
Fixes #8080