Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] gatsby servebugs #8080

Closed
jquense opened this issue Sep 12, 2018 · 6 comments · Fixed by #11581
Closed

[v2] gatsby servebugs #8080

jquense opened this issue Sep 12, 2018 · 6 comments · Fixed by #11581
Labels
status: needs more info Needs triaging and reproducible examples or more information to be resolved

Comments

@jquense
Copy link
Contributor

jquense commented Sep 12, 2018 •
edited
Loading

Running the latest v2 rc:

  • ctrl +c doesn't exit the server this seems to be just me
  • client paths aren't handled and result in a 404, might need the history fallback middleware
  • keeps trying to send a non-existent 404 page on any client route'

maaaybe more, still checking
@kakadiadarpan
Copy link
Contributor

Hi @jquense, can you please provide more information on this? Also, I'm able to successfully exit the server using ctrl + c.

@kakadiadarpan kakadiadarpan added the status: needs more info Needs triaging and reproducible examples or more information to be resolved label Sep 13, 2018
@jquense
Copy link
Contributor Author

jquense commented Sep 13, 2018

@kakadiadarpan you're right it seems like something is funky in my env that it's not exiting. The other two issues are still relevant tho. I can hopefully throw a fix together for it

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 4, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 4, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@jquense
Copy link
Contributor Author

jquense commented Jan 4, 2019

Still relevant I believe

@m-allanson m-allanson added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Jan 4, 2019
@sidharthachatterjee sidharthachatterjee mentioned this issue Jan 4, 2019
Closed
@moonmeister
Copy link
Contributor

moonmeister commented Feb 3, 2019 •
edited
Loading

gatsby serve -H <ipaddress> runs without error, and is shown in help as a valid option but the serve code doesn't ever reference host and it'll always serve to localhost.

Reproduce:
gatsby serve --help to see inacurate help data

gatsby serve -H <random address> to see it still prints and functions on localhost.

UPDATE: fixed in #11566

@zauni zauni mentioned this issue Feb 5, 2019
Merged
DSchau pushed a commit that referenced this issue Feb 5, 2019
@zauni @DSchau
fix(gatsby-cli): use host option if it is passed (#11566)
ec15b04 
## Description

The serve command didn't use the "--host" option and just used localhost.
It got deleted in commit bff0cd3

## Related Issues

Related to #8080
DSchau added a commit to DSchau/gatsby that referenced this issue Feb 5, 2019
@DSchau
fix(gatsby): use history fallback to display client-only routes in serve
079140a 
As best as I can tell--this fixes a few issues identified with
client-only routes, without causing a regression in existing
functionality.

What I validated:

- Client only routes work (and work on initial navigation, e.g. given
dynamic path /app/1234, it works when navigated to and on initial route)
- Existing routes created via SSR work
- 404 routes work (and direct 404.html route)

Fixes gatsbyjs#8080
@DSchau DSchau mentioned this issue Feb 5, 2019
Merged
DSchau added a commit that referenced this issue Feb 6, 2019
@DSchau
fix(gatsby): use history fallback to display client-only routes in se…
75f6118 
…rve (#11581)

As best as I can tell--this fixes a few issues identified with
client-only routes, without causing a regression in existing
functionality.

What I validated:

- Client only routes work (and work on initial navigation, e.g. given
dynamic path /app/1234, it works when navigated to and on initial route)
- Existing routes created via SSR work
- 404 routes work (and direct 404.html route)

Fixes #8080
@DSchau
Copy link
Contributor

DSchau commented Feb 6, 2019 

Successfully published:
 - [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs more info Needs triaging and reproducible examples or more information to be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gatsby): use history fallback to display client-only routes in serve DSchau/gatsby
6 participants
@jquense @m-allanson @moonmeister @DSchau @kakadiadarpan @LekoArts