-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(production-e2e): Add offline tests #10940
Conversation
…nto add-offline-tests
Gatsbygram tests failed due to a segfault, not due to code changes here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in - ideally we could adjust config a bit so it's more clear when production-runtime tests in offline or non-offline mode - right now there is single step ./scripts/e2e-test.sh "e2e-tests/production-runtime" "yarn test && yarn test:offline"
, but it's better to have those tests at all.
Thanks @davidbailey00!
Changes:
CYPRESS_SUPPORT
env variable for whether to enable Cypress API hooks, and when running tests, set this variableTEST_PLUGIN_OFFLINE
env variable to determine whether or not to install the offline plugin when testingproduction-runtime
tests also now run both without and withgatsby-plugin-offline
chromeWebSecurity
forproduction-runtime
tests because it doesn't work with service workers :(