-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress tests for built site & gatsby-plugin-offline #7421
Comments
Here's an updated version of the checklist, with some clearer descriptions:
Regarding the PR, currently tests 4.1.1 and 4.1.2 (i.e. custom 404s with |
@KyleAMathews @davidbailey00 On it! 👍 |
@shobhitchittora Awesome, thanks! Also since I made the last comment, all tests are now passing in the PR but various ones will fail with the current latest version of Gatsby. |
We should explore this more. Get some basic tests for gatsby-plugin-offline to see if they're reliable and then continue to test smaller edge cases. Perhaps helpful: cypress-io/cypress#702 /cc @davidbailey00 |
@KyleAMathews I've still got a branch in progress where I've added some tests - still haven't opened a PR because other bugs have popped up which I've shifted my focus onto. Will try to continue work on this branch next week. (Link: https://github.com/davidbailey00/gatsby/tree/add-offline-tests) |
Perfect! Thanks for the update! |
Closed by #10940 |
We should automatically verify Gatsby's production run-time with a Cypress test suite, similar to what we've added for Gatsbygram & the develop runtime.
The tests should build the site and then verify various things like 404 support, visiting pages, clicking on links, various types of offline support etc.
@davidbailey00 has created a great list of manual checks @ #7355 (comment)
We should develop tests to automatically run the same tests on PRs.
First step is to setup a basic test that builds the site and runs a few basic tests. Then we extend that to run more and more tests.
The text was updated successfully, but these errors were encountered: