Removing deprecated puppetlabs-apt properties to remove deprecation notices #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `key_source` and `required_packages` properties are deprecated and `key` should now be a hash instead of a string. I'm not sure the best way to handle the required packages so I've moved them to an `ensure_packages` call for now and made that a requirement of the apt resource.
tizzo
changed the title
|
Also discussed in #315 |
| 'server' => 'hkp://keyserver.ubuntu.com:80', | ||
| }, | ||
| pin => '10', | ||
| require => [ |
There was a problem hiding this comment.
the requires here exacerbates the issue discussed in #369
also note puppetlabs/puppetlabs-apt#427 (comment)
The idea here was that for some repositories you need a package installed that provides the keys for the repo. In the case of the main Debian repositories, the debian(-archive)-keyring packages.
However, if you manage to install a Debian system without those packages you deserve what's coming to you, a world of pain.
I suggest not managing those packages in this puppet-module.
This was referenced Mar 29, 2016
This was referenced Jun 9, 2016
|
Is it going to be merged? |
|
+1 ... can this be merged |
cegeka-jenkins
pushed a commit
to cegeka/puppet-docker
that referenced
this pull request
Apr 17, 2024
* wip: updated README to include aws logging option details added in pull request garethr#354 * wip: corrected formatting * wip: corrected formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
key_sourceandrequired_packagesproperties are deprecated andkeyshould now be a hash instead of a string. I'm not sure the best way to handle the required packages so I've moved them to anensure_packagescall for now and made that a requirement of the apt resource.Addresses #455.