Updating to avoid key_source and include_src depreciation warnings from puppetlabs-apt #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 3, 2015 13:31
Conflicts: manifests/install.pp spec/acceptance/docker_spec.rb
|
@ChrisCrewdson thanks. This does indeed only work with the 2 series of the apt module. I'm not going to merge this at this point as doing so forces anyone using this module to update the apt module. I'd rather wait for that to bed down a little and then make the change given it's just implementation. 2.1 of the apt module is backwards compatible so it's not a problem apart from the deprecation warnings. |
|
It's been quite a while now. Should this be merged? (2.1 has been released a year ago) |
|
This pull request is out of date and no longer works on master. Use #459 Instead. |
|
Closing this very old PR in favor #459. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-docker
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this change needs to be locked to a specific puppetlabs-apt version, but it passes all the current tests.