Support Hyperdisk Params #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
kon-angelo
reviewed
Apr 27, 2024
pkg/gcp/machine_controller_util.go
Outdated
| attachedDisk := compute.AttachedDisk{ | ||
| Type: validation.DiskTypePersistent, | ||
| Boot: disk.Boot, | ||
| AutoDelete: false, |
There was a problem hiding this comment.
Maybe AutoDelete: ptr.Deref(disk.AutoDelete, false) and delete the other code below that does this
There was a problem hiding this comment.
Good suggestion, but shouldn't it be then AutoDelete: ptr.Deref(disk.AutoDelete, true)?
kon-angelo
reviewed
Apr 27, 2024
| if disk.AutoDelete == nil || *disk.AutoDelete == true { | ||
| autoDelete = true | ||
| attachedDisk := compute.AttachedDisk{ | ||
| Type: validation.DiskTypePersistent, |
There was a problem hiding this comment.
Isn't it better as a general case to pass the disk.Type here that you anyway get from the input, rather than "assuming" the PERSISTENT ?
There was a problem hiding this comment.
There are two types of disk type.
The actual disk type has two possible values: "PERSISTENT" and "SCRATCH".
The disk type we pass is the AttachedDiskInitializeParams.DiskType.
|
@hebelsan You need rebase this pull request with latest master branch. Please check. |
gardener-robot-ci-3
added
reviewed/ok-to-test
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.57.0...v1.57.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
* Enhanced the local_integration_test script * Improved the local_integration_test script * Modified cloning of MCM in pipeline
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
Closed in favor of: #122 |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for passing disk params provisioned-iops and provisioned-throughput
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: