Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for hyperdisk params #743

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Support for hyperdisk params #743

merged 10 commits into from
Jun 24, 2024

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented Apr 26, 2024 •
edited
Loading

How to categorize this PR?

/area quality
/kind enhancement
/platform gcp

What this PR does / why we need it:
Support and validation of disk params provisioned-iops and provisioned-throughput

Which issue(s) this PR fixes:
Fixes #702

Special notes for your reviewer:

Release note:

Support and validation of disk params provisioned-iops and provisioned-throughput

@hebelsan hebelsan requested review from a team as code owners April 26, 2024 15:07
@gardener-robot gardener-robot added needs/review Needs review kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 26, 2024
@hebelsan
Copy link
Contributor Author

MCM PR: gardener/machine-controller-manager-provider-gcp#121

kon-angelo
kon-angelo reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 8, 2024
@hebelsan
Copy link
Contributor Author

Needs some adjustment (should be configurable per dataVolume disk) as specified here:
#751

AndreasBurger
AndreasBurger previously approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/controller/worker/machines.go Outdated Show resolved Hide resolved
pkg/apis/gcp/validation/shoot.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jun 10, 2024
@gardener-robot
Copy link

@hebelsan You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Jun 10, 2024
@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@hebelsan
Copy link
Contributor Author

/hold Need for change: should be configurable per dataVolume disk as specified here #751

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@hebelsan
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 20, 2024
@AndreasBurger AndreasBurger merged commit 90adc99 into gardener:master Jun 24, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo left review comments

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else platform/gcp Google cloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Google Cloud Hyperdisk storage in worker volume types
7 participants
@hebelsan @gardener-robot @AndreasBurger @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3