Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use passed ConnectConfig when creating clients #157

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Always use passed ConnectConfig when creating clients #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d559b66
always use passed ConnectConfig when creating clients
AndreasBurger Jun 26, 2024
7b52835
address review comments
AndreasBurger Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/azure/access/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,61 +54,61 @@ func (f defaultFactory) GetResourceGroupsAccess(connectConfig ConnectConfig) (*a
if err != nil {
return nil, err
}
return armresources.NewResourceGroupsClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armresources.NewResourceGroupsClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetVirtualMachinesAccess(connectConfig ConnectConfig) (*armcompute.VirtualMachinesClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armcompute.NewVirtualMachinesClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armcompute.NewVirtualMachinesClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetNetworkInterfacesAccess(connectConfig ConnectConfig) (*armnetwork.InterfacesClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armnetwork.NewInterfacesClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armnetwork.NewInterfacesClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetSubnetAccess(connectConfig ConnectConfig) (*armnetwork.SubnetsClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armnetwork.NewSubnetsClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armnetwork.NewSubnetsClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetDisksAccess(connectConfig ConnectConfig) (*armcompute.DisksClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armcompute.NewDisksClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armcompute.NewDisksClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetResourceGraphAccess(connectConfig ConnectConfig) (*armresourcegraph.Client, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armresourcegraph.NewClient(tokenCredential, f.clientOptions)
return armresourcegraph.NewClient(tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetVirtualMachineImagesAccess(connectConfig ConnectConfig) (*armcompute.VirtualMachineImagesClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armcompute.NewVirtualMachineImagesClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armcompute.NewVirtualMachineImagesClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}

func (f defaultFactory) GetMarketPlaceAgreementsAccess(connectConfig ConnectConfig) (*armmarketplaceordering.MarketplaceAgreementsClient, error) {
tokenCredential, err := f.tokenCredentialProvider(connectConfig)
if err != nil {
return nil, err
}
return armmarketplaceordering.NewMarketplaceAgreementsClient(connectConfig.SubscriptionID, tokenCredential, f.clientOptions)
return armmarketplaceordering.NewMarketplaceAgreementsClient(connectConfig.SubscriptionID, tokenCredential, &arm.ClientOptions{ClientOptions: connectConfig.ClientOptions})
}