Always use passed ConnectConfig when creating clients #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/xs
gardener-robot-ci-2
added
needs/ok-to-test
rishabh-11
suggested changes
Jun 27, 2024
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
rishabh-11
pushed a commit
to rishabh-11/machine-controller-manager-provider-azure
that referenced
this pull request
Jul 18, 2024
Always use passed ConnectConfig when creating clients
rishabh-11
added a commit
that referenced
this pull request
Jul 18, 2024
Always use passed ConnectConfig when creating clients Co-authored-by: Andreas Burger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a follow-up to #148. Due to an oversight, the previous change caused only the authentication to connect to the intended cloud.
I've obtained some credentials for other Instances in the meantime and was able to verify that with these changes, creating Machines on other Providers can succeed.
Special notes for your reviewer:
I've gone ahead and made the passed ConnectConfig the source of truth for the connection-options. One could think about merging it with the factory-provided options, but since these are currently always the default options I've decided not to do this for now.
Release note: