Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize VM Updates, Fix OSDisk name and extraction of VM name from DataDisk #117

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Optimize VM Updates, Fix OSDisk name and extraction of VM name from DataDisk #117

merged 4 commits into from
Nov 28, 2023

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Nov 27, 2023 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
Fixes multiple issues. Please see relevant issues to get further details.
Apart from these issues it also updates the azure package dependency versions

Dependency: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5 
Updated from: v5.3.0-beta.2 to v5.3.0
--------------------------------------------------------------------------------------------------------------
Dependency: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplaceordering/armmarketplaceordering
Updated from: v1.2.0-beta.3 to v1.2.0
--------------------------------------------------------------------------------------------------------------
Dependency: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4
Updated from: v4.3.0-beta.1 to v4.3.0
--------------------------------------------------------------------------------------------------------------
Dependency: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources
Updated from: v1.2.0-beta.3 to v1.2.0

Which issue(s) this PR fixes:
Fixes #113 #114 #116
Partially fixes #115

Special notes for your reviewer:

Release note:

Updated the following dependencies:
--------------------------------------------------------------------------------------------------------------
* github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5 [v5.3.0-beta.2 to v5.3.0]
* github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/marketplaceordering/armmarketplaceordering [v1.2.0-beta.3 to v1.2.0]
* github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4 [v4.3.0-beta.1 to v4.3.0]
* github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources [v1.2.0-beta.3 to v1.2.0]

@unmarshall unmarshall requested review from a team as code owners November 27, 2023 08:08
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 27, 2023
himanshu-kun
himanshu-kun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The IT are failing in pipeline, could you run them once locally , if they are passing locally , then kindly re-trigger the tests.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 27, 2023
rishabh-11
rishabh-11 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the changes

@unmarshall unmarshall merged commit ccae97d into gardener:master Nov 28, 2023
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2023
@rishabh-11 rishabh-11 deleted the optimize-vmupdate branch January 31, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@unmarshall unmarshall

@himanshu-kun himanshu-kun

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
7 participants
@unmarshall @rishabh-11 @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot