Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS Disk name #114

Closed
unmarshall opened this issue Nov 23, 2023 · 1 comment
Closed

Fix OS Disk name #114

unmarshall opened this issue Nov 23, 2023 · 1 comment
Assignees
Labels
kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)

Comments

@unmarshall
Copy link
Contributor

What happened:
The new code broke the naming convention with which OS Disks are created. In the case the VM is created with cascade delete set for OS Disk this will not be an issue. Since the cleanup of OS Disk will also happen when the VM is deleted. However, in case there is an older VM which does not have a cascade delete policy set for OS Disk and assume that the VM no longer exists. In that case when the new code attempts to delete the left over NICs and Disks (OS and Data disks) then it will delete everything except OS Disk due to bug in the way OS Disk name is created. There is an extra hyphen in the name that gets added.

What you expected to happen:
The OS Disk name should be correctly created

How to reproduce it (as minimally and precisely as possible):
Create a machine, delete the VM using az cli or azure portal and then delete the machine.

@unmarshall unmarshall added the kind/bug Bug label Nov 23, 2023
@unmarshall unmarshall self-assigned this Nov 23, 2023
@unmarshall unmarshall added the priority/1 Priority (lower number equals higher priority) label Nov 23, 2023
@himanshu-kun
Copy link
Contributor

/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

3 participants