-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write and symlink kubeconfig on change of target #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nice, waiting to get this feature 👍 |
b2d6bf5
to
0aaaa8f
Compare
f452990
to
e22415e
Compare
…t set to kubectl sesssion kubeconfig filename
8708b0b
to
b8f5389
Compare
petersutter
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR it is possible to change the target cluster of
kubectl
directly with thegardenctl target ...
command without having to adjust theKUBECONFIG
environment variable again and again. Whether the current target cluster of gardenctl and kubectl should be synchronized or not can be set using the configrations property link-kubeconfig or via environment variableGCTL_LINK_KUBECONFIG
.Behavior without symlink | linkKubeconfig: false
The

target
command only changes the current target cluster of gardenctl, but does not download the corresponding kubeconfig file. This happens only when thekubectl-env
command is executed. If the user evals the generated script theKUBECONFIG
environment variable points the downloaded kubeconfig file for the targeted cluster.The generated script looks something like this:
Behavior with symlink | linkKubeconfig: true
The

target
command changes the current target cluster of gardenctl, downloads the corresponding kubeconfig file and creates a stable symlink to the current kubeconfig file in the session directory. If the target is changed the symlink points to the new target but theKUBECONFIG
environment variable does not need to be changed. Thekubectl-env
command now does nothing except create the script to set theKUBECONFIG
environment variable. This works even if nothing is targeted and could be done in the shell profile.The generated script only needs to be evaluated once per shell session and looks something like this:
Test
Test are not yet changed !!!
Which issue(s) this PR fixes:
Fixes #81
Special notes for your reviewer:
Release note: