-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shell #1158
Remove shell #1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold until we have adapted the rc command in gardenctl to also eval the kubectl-env command |
@petersutter You need rebase this pull request with latest master branch. Please check. |
/unhold |
1312f90
to
cd9469f
Compare
What this PR does / why we need it:
With gardener/gardenctl-v2#86 it is now easier to target a (shoot) cluster. Running
eval $(gardenctl kubectl-env bash)
after running the target command is not required any more to set theKUBECONFIG
env variable. Instead, it only has to be run once (e.g. by including it into the shell profile). See more details here https://github.com/gardener/gardenctl-v2/blob/master/docs/concepts/cli_interaction.md#behavior-with-symlinkWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: