Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shell #1158

Merged
merged 1 commit into from
May 10, 2022
Merged

Remove shell #1158

merged 1 commit into from
May 10, 2022

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Feb 16, 2022

What this PR does / why we need it:
With gardener/gardenctl-v2#86 it is now easier to target a (shoot) cluster. Running eval $(gardenctl kubectl-env bash) after running the target command is not required any more to set the KUBECONFIG env variable. Instead, it only has to be run once (e.g. by including it into the shell profile). See more details here https://github.com/gardener/gardenctl-v2/blob/master/docs/concepts/cli_interaction.md#behavior-with-symlink

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `gardenctl-v2` commands that can be copied from the cluster details page to target the "Cluster" or the "Control Plane" will not include the command to set the `KUBECONFIG` environment variable anymore (e.g. `eval $(gardenctl kubectl-env bash)` in case of `bash`)
- A warning message is displayed when running the `target` command in case the `KUBECONFIG` environment variable does not point to the current target
- The [`rc` command](https://github.com/gardener/gardenctl-v2/blob/master/docs/help/gardenctl_rc.md) startup script sets the `KUBECONFIG` variable when evaluating the command output, usually as part of the shell profile, e.g. `source <(gardenctl rc bash)` in case of `bash`. Requires `gardenctl` `v2.1.0`
- If you do not load the `gardenctl` `rc` command in your shell profile or do not have the `gk` or, with `bash` as an example,  `eval "$(gardenctl kubectl-env bash)"` in your `bash` profile, you will have to run it manually in order to have the `KUBECONFIG` point to the kubeconfig of the current target

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 16, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 16, 2022
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 16, 2022
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 24, 2022
@petersutter
Copy link
Member Author

/hold until we have adapted the rc command in gardenctl to also eval the kubectl-env command

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 7, 2022
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Apr 4, 2022
@gardener-robot
Copy link

@petersutter You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Apr 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2022
@petersutter
Copy link
Member Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 9, 2022
@petersutter petersutter force-pushed the enh/gardenctl-v2-link branch from 1312f90 to cd9469f Compare May 9, 2022 15:00
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2022
@petersutter petersutter merged commit b204b57 into master May 10, 2022
@petersutter petersutter deleted the enh/gardenctl-v2-link branch May 10, 2022 10:24
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants