upgraded go version to 1.22.1 #780

unmarshall · 2024-04-03T05:21:30Z

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Upgrades golang version to 1.22.1

Which issue(s) this PR fixes:
Fixes #778

Special notes for your reviewer:

Release note:

etcd-druid now uses golang version 1.22.1

unmarshall · 2024-04-03T05:24:02Z

All unit tests passed locally
make test

go build -o hack/tools/bin/ginkgo github.com/onsi/ginkgo/v2/ginkgo
go build -o hack/tools/bin/setup-envtest sigs.k8s.io/controller-runtime/tools/setup-envtest
> Installing envtest [email protected] with setup-envtest if necessary
using envtest tools installed at '/Users/i062009/Library/Application Support/io.kubebuilder.envtest/k8s/1.22.1-darwin-amd64'
> Tests
[1712121732] Condition Suite - 19/19 specs ••••••••••••••••••• SUCCESS! 2.201625ms PASS
[1712121732] RoleBinding Component Suite - 7/7 specs ••••••• SUCCESS! 1.283ms PASS
[1712121732] Configmap Component Suite - 4/4 specs •••• SUCCESS! 2.05225ms PASS
[1712121732] Controller Utils suite - 8/8 specs •••••••• SUCCESS! 505.792µs PASS
[1712121732] Utils Suite - 19/19 specs ••••••••••••••••••• SUCCESS! 3.367958ms PASS
[1712121732] Metrics Suite - 4/4 specs •••• SUCCESS! 310.542µs PASS
[1712121732] Mapper Suite - 6/6 specs •••••• SUCCESS! 929.708µs PASS
[1712121732] Etcd Controller Suite - 0/0 specs  SUCCESS! 93.916µs PASS
[1712121732] EtcdCopyBackupsTask Controller Suite - 59/59 specs ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 6.546209ms PASS
[1712121732] Secret Controller Suite - 10/10 specs •••••••••• SUCCESS! 1.539208ms PASS
[1712121732] Predicate Suite - 25/25 specs ••••••••••••••••••••••••• SUCCESS! 1.950375ms PASS
[1712121732] Service Component Suite - 10/10 specs •••••••••• SUCCESS! 2.351333ms PASS
[1712121732] PodDisruptionBudget Component Suite - 8/8 specs •••••••• SUCCESS! 4.425583ms PASS
[1712121732] ServiceAccount Component Suite - 8/8 specs •••••••• SUCCESS! 1.234417ms PASS
[1712121732] Etcd Component Suite - 6/6 specs •••••• SUCCESS! 3.083542ms PASS
[1712121732] Status Suite - 1/1 specs • SUCCESS! 374.125µs PASS
[1712121732] Role Component Suite - 7/7 specs ••••••• SUCCESS! 1.662166ms PASS
[1712121732] Etcd Member Suite - 9/9 specs ••••••••• SUCCESS! 1.364541ms PASS
[1712121732] Statefulset Component Suite - 21/21 specs ••••••••••••••••••••• SUCCESS! 13.41475ms PASS
[1712121732] Etcd Validation Suite - 13/13 specs ••••••••••••• SUCCESS! 1.494625ms PASS
[1712121732] v1 Suite - 13/13 specs ••••••••••••• SUCCESS! 8.130741083s PASS

unmarshall · 2024-04-03T05:31:22Z

All integration-tests passed locally:
make test-integration

> Installing envtest [email protected] with setup-envtest if necessary
using envtest tools installed at '/Users/i062009/Library/Application Support/io.kubebuilder.envtest/k8s/1.22.1-darwin-amd64'
> Tests
[1712121797] Custodian Controller Suite - 4/4 specs •••• SUCCESS! 10.306124042s PASS
[1712121797] Secret Controller Suite - 1/1 specs • SUCCESS! 7.543844125s PASS
[1712121797] EtcdCopyBackupsTask Controller Suite - 8/8 specs •••••••• SUCCESS! 1m12.938228167s PASS
[1712121797] Compaction Controller Suite - 10/10 specs •••••••••• SUCCESS! 40.641160209s PASS
[1712121797] Etcd Controller Suite - 37/37 specs ••••••••••••••••••••••••••••••••••••• SUCCESS! 5m16.414722208s PASS

Ginkgo ran 5 suites in 7m35.347779375s
Test Suite Passed

aaronfern · 2024-04-03T05:40:59Z

Did you run make revendor?
Just curious because I do not see any changes in go.sum

unmarshall · 2024-04-03T05:56:25Z

Did you run make revendor? Just curious because I do not see any changes in go.sum

I did not run this specific target but i ran go mod vendor followed by go mod tidy which effectively does the same as the revendor target. You can pull this PR and check if you are facing any issues.

unmarshall · 2024-04-03T07:57:25Z

Ran e2e tests locally:
make ci-e2e-kind

Run #1
There were a total of 3 failing tests:

Summarizing 3 Failures:
  [FAIL] Etcd when a single-node is configured [It] should scale a single-node etcd (TLS not enabled for peerUrl) to a multi-node etcd cluster (TLS enabled for peerUrl)
  /Users/i062009/src/github.com/unmarshall/etcd-druid/test/e2e/etcd_multi_node_test.go:390
  [FAIL] Etcd when a single-node is configured [It] should scale down a single-node etcd to 0 replica, then scale up from 0->1 replica and then from 1->3 replicas with TLS enabled for cluster peerUrl
  /Users/i062009/src/github.com/unmarshall/etcd-druid/test/e2e/etcd_multi_node_test.go:390
  [FAIL] Etcd Compaction when compaction is enabled for single-node etcd with provider aws [It] should test compaction on backup
  /Users/i062009/src/github.com/unmarshall/etcd-druid/test/e2e/etcd_compaction_test.go:151

Ran 7 of 7 Specs in 1782.468 seconds
FAIL! -- 4 Passed | 3 Failed | 0 Pending | 0 Skipped

Run #2
Second time i added Focus to multi-node tests and this time all focussed tests passed.

1. Etcd when a single-node is configured should scale a single-node etcd (TLS not enabled for peerUrl) to a multi-node etcd cluster (TLS not enabled for peerUrl)
2. Etcd when a single-node is configured should scale a single-node etcd (TLS not enabled for peerUrl) to a multi-node etcd cluster (TLS enabled for peerUrl)
3. Etcd when a single-node is configured should scale down a single-node etcd to 0, then scale up from 0->1 replicas and then from 1->3 replicas
4. Etcd when a single-node is configured should scale down a single-node etcd to 0 replica, then scale up from 0->1 replica and then from 1->3 replicas with TLS enabled for cluster peerUrl

Run #3
In this added focus to compaction tests. This time all tests passed:

Etcd Compaction when compaction is enabled for single-node etcd with provider aws should test compaction on backup

So there seems to be some flakiness in the tests which we will have to investigate.

shreyas-s-rao · 2024-04-03T10:51:42Z

Reduced flakiness in downtime validator job based tests in e2e test suite.

-------------------
Running e2e tests
-------------------
=== RUN   TestIntegration
Running Suite: e2e Suite - /Users/i349079/go/src/github.com/gardener/etcd-druid/test/e2e
========================================================================================
Random Seed: 1712133003

Will run 1 of 7 specs
------------------------------
[BeforeSuite] 
/Users/i349079/go/src/github.com/gardener/etcd-druid/test/e2e/suite_test.go:62
  > Enter [BeforeSuite] TOP-LEVEL @ 04/03/24 14:00:03.236
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"creating namespace","namespace":"shoot"}
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"creating secret","secret":{"namespace":"shoot","name":"ca-etcd-aws"}}
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"creating secret","secret":{"namespace":"shoot","name":"etcd-server-cert-aws"}}
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"creating secret","secret":{"namespace":"shoot","name":"etcd-client-tls-aws"}}
  < Exit [BeforeSuite] TOP-LEVEL @ 04/03/24 14:00:03.346 (110ms)
[BeforeSuite] PASSED [0.113 seconds]
------------------------------
SS
------------------------------
Etcd when multi-node is configured should perform etcd operations
/Users/i349079/go/src/github.com/gardener/etcd-druid/test/e2e/etcd_multi_node_test.go:77
  > Enter [BeforeEach] Etcd @ 04/03/24 14:00:03.349
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"creating secret","secret":{"namespace":"shoot","name":"etcd-backup-aws"}}
  < Exit [BeforeEach] Etcd @ 04/03/24 14:00:03.389 (39ms)
  > Enter [It] should perform etcd operations @ 04/03/24 14:00:03.389
  STEP: Create etcd @ 04/03/24 14:00:03.389
  {"level":"info","ts":"2024-04-03T14:00:03+05:30","msg":"Waiting for etcd to become ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:02:58+05:30","msg":"etcd is ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:02:58+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:02:58+05:30","msg":"Checking configmap","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:02:58+05:30","msg":"Checking client service","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Hibernate etcd (Scale down from 3 replicas to 0) @ 04/03/24 14:02:58.724
  {"level":"info","ts":"2024-04-03T14:02:58+05:30","msg":"Waiting for statefulset spec to reflect change in replicas to 0","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:03:00+05:30","msg":"Checking etcd","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:03:02+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:03:02+05:30","msg":"etcd is hibernated","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Wakeup etcd (Scale up from 0->3 replicas) @ 04/03/24 14:03:02.769
  {"level":"info","ts":"2024-04-03T14:05:09+05:30","msg":"Waiting for etcd to become ready"}
  {"level":"info","ts":"2024-04-03T14:05:19+05:30","msg":"etcd is ready"}
  {"level":"info","ts":"2024-04-03T14:05:19+05:30","msg":"Checking statefulset"}
  {"level":"info","ts":"2024-04-03T14:05:19+05:30","msg":"Checking configmap"}
  {"level":"info","ts":"2024-04-03T14:05:19+05:30","msg":"Checking client service"}
  STEP: Zero downtime rolling updates @ 04/03/24 14:05:19.712
  {"level":"info","ts":"2024-04-03T14:05:19+05:30","msg":"Creating job to ensure etcd zero downtime","job":"etcd-zero-down-time-validator-rolling-update"}
  {"level":"info","ts":"2024-04-03T14:05:35+05:30","msg":"Job is ready","job":"etcd-zero-down-time-validator-rolling-update"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Waiting for etcd to become ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"etcd is ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Checking configmap","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Checking client service","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Etcd Cluster is healthy and there is no downtime","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Zero downtime maintenance operation: defragmentation @ 04/03/24 14:06:42.156
  {"level":"info","ts":"2024-04-03T14:06:42+05:30","msg":"Configure defragmentation schedule for every 1 minute","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Waiting for etcd to become ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"etcd is ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Checking configmap","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Checking client service","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Etcd Cluster is healthy and there is no downtime","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:07:48+05:30","msg":"Waiting for defragmentation to finish","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:01+05:30","msg":"Defragmentation is finished","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:01+05:30","msg":"Checking any Etcd downtime","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:01+05:30","msg":"Etcd Cluster is healthy and there is no downtime","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Member restart with data-dir/pvc intact @ 04/03/24 14:09:01.264
  {"level":"info","ts":"2024-04-03T14:09:01+05:30","msg":"Delete one member pod","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:01+05:30","msg":"waiting for sts to become unready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:03+05:30","msg":"sts is unready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:03+05:30","msg":"Waiting for etcd to become ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:17+05:30","msg":"etcd is ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:17+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:17+05:30","msg":"Checking configmap","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:17+05:30","msg":"Checking client service","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Single member restoration @ 04/03/24 14:09:17.393
  {"level":"info","ts":"2024-04-03T14:09:17+05:30","msg":"Create debug pod","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:29+05:30","msg":"Delete member dir of one member pod","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:09:29+05:30","msg":"waiting for sts to become unready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:01+05:30","msg":"sts is unready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:01+05:30","msg":"Waiting for etcd to become ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:15+05:30","msg":"etcd is ready","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:15+05:30","msg":"Checking statefulset","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:15+05:30","msg":"Checking configmap","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:15+05:30","msg":"Checking client service","etcd-multi-node":"shoot/etcd-aws"}
  STEP: Delete debug pod @ 04/03/24 14:10:15.798
  STEP: Delete etcd @ 04/03/24 14:10:15.801
  {"level":"info","ts":"2024-04-03T14:10:15+05:30","msg":"Checking if etcd is gone","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:17+05:30","msg":"Checking if statefulset is gone","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:17+05:30","msg":"Checking if configmap is gone","etcd-multi-node":"shoot/etcd-aws"}
  {"level":"info","ts":"2024-04-03T14:10:17+05:30","msg":"Checking client service is gone","etcd-multi-node":"shoot/etcd-aws"}
  < Exit [It] should perform etcd operations @ 04/03/24 14:10:17.856 (10m14.466s)
  > Enter [AfterEach] Etcd @ 04/03/24 14:10:17.856
  < Exit [AfterEach] Etcd @ 04/03/24 14:10:17.859 (3ms)
• [614.508 seconds]
------------------------------
SSSS
------------------------------
[AfterSuite] 
/Users/i349079/go/src/github.com/gardener/etcd-druid/test/e2e/suite_test.go:98
  > Enter [AfterSuite] TOP-LEVEL @ 04/03/24 14:10:17.859
  {"level":"info","ts":"2024-04-03T14:10:17+05:30","msg":"deleting namespace","namespace":"shoot","namespace":"shoot"}
  < Exit [AfterSuite] TOP-LEVEL @ 04/03/24 14:10:49.991 (32.132s)
[AfterSuite] PASSED [32.132 seconds]
------------------------------

Ran 1 of 7 Specs in 646.754 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 6 Skipped
PASS | FOCUSED

shreyas-s-rao · 2024-04-03T13:28:19Z

/retest

shreyas-s-rao · 2024-04-03T15:45:59Z

/retest

shreyas-s-rao · 2024-04-03T16:02:40Z

/retest

shreyas-s-rao · 2024-04-03T16:15:27Z

/retest

shreyas-s-rao · 2024-04-03T16:51:10Z

Prow jobs for e2e tests are passing now. Seems to be some flakiness, which we will re-look at in another PR.
/invite @ishan16696 PTAL

ishan16696 · 2024-04-05T03:45:37Z

I did not run this specific target but i ran go mod vendor followed by go mod tidy which effectively does the same as the revendor target. You can pull this PR and check if you are facing any issues

yes, I tried that ..it works fine

ishan16696

LGTM!!

ishan16696 · 2024-04-05T03:51:09Z

make check failed locally

go build -o hack/tools/bin/goimports golang.org/x/tools/cmd/goimports
go build -o hack/tools/bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen
Generating CRDs for druid.gardener.cloud group
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104c7cd94]

goroutine 6 [running]:
go/types.(*Checker).handleBailout(0x14000392000, 0x1400014fd18)
	/Users/I539698/go/pkg/mod/golang.org/[email protected]/src/go/types/check.go:367 +0x9c
panic({0x104f4d480?, 0x1054ebe40?})
	/Users/I539698/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:770 +0x124
go/types.(*StdSizes).Sizeof(0x0, {0x105017a70, 0x1054f4660})
	/Users/I539698/go/pkg/mod/golang.org/[email protected]/src/go/types/sizes.go:228 +0x314
go/types.(*Config).sizeof(...)

renormalize · 2024-04-08T03:55:03Z

What's happening is quite interesting.

make check is run with go1.21:
It runs successfully for all commits (release tags v0.18.0 to v0.22.0, and master at 9c5f825), except this PR - since make check obviously needs go1.22.1 for this PR.
make check is run with go1.22.1:
It fails to run successfully with all commits in etcd-druid after v0.19.0, not just this PR. There is some commit between v0.18.0 and v0.19.0 where make check would start failing if run with go1.22.1.

When make check is run on #748, which upgrades gardener/gardener to v1.86.0 (and thereby all gardener/gardener dependencies that are used in etcd-druid), by testing with go1.22.1, the checks are successful.

The commit at which this branch (shreyas-s-rao:dep/gardener-v1.86.0) diverges from master - 7bd94c4 (v0.22.0), has its checks fail with make check with go1.22.1.

The dependencies for the check target at their current versions are failing to work correctly with go1.22.1 somehow, and upgrading all of them to the versions seen in gardener/gardener v1.86.0 might solve this.

I've tried debugging the panics that are being seen currently, but they're certainly out of my wheelhouse.

…to v0.14.0 and adpted code

gardener-prow · 2024-04-08T08:09:17Z

@unmarshall: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-druid-e2e-kind	`2a6e615`	link	true	`/test pull-etcd-druid-e2e-kind`
pull-etcd-druid-e2e-kind-nondistroless-etcd	`2a6e615`	link	true	`/test pull-etcd-druid-e2e-kind-nondistroless-etcd`

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

unmarshall · 2024-04-11T16:56:04Z

/close in favor of another pull request.

unmarshall · 2024-04-11T16:56:17Z

Another PR will be raised.

shreyas-s-rao · 2024-04-14T15:05:19Z

Superseded by #784

upgraded go version to 1.22.1

11c48ec

unmarshall requested a review from a team as a code owner April 3, 2024 05:21

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2024

gardener-robot added the needs/review Needs review label Apr 3, 2024

gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 3, 2024

gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 3, 2024

unmarshall assigned shreyas-s-rao Apr 3, 2024

shreyas-s-rao added this to the v0.23.0 milestone Apr 3, 2024

Reduce flakiness in e2e tests

b82421c

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 3, 2024

gardener-robot requested a review from ishan16696 April 3, 2024 16:51

ishan16696 approved these changes Apr 5, 2024

View reviewed changes

ishan16696 self-requested a review April 5, 2024 03:51

ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 5, 2024

removed dependency on g/g check.sh, changed controller-tools version …

2159238

…to v0.14.0 and adpted code

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2024

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 8, 2024

added goimports and changed the version of golangci-lint to v.1.57.2

5d288fe

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 8, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 8, 2024

removed dependency on g/g for scripts

2a6e615

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2024

unmarshall closed this Apr 11, 2024

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2024

unmarshall deleted the goversion branch July 1, 2024 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgraded go version to 1.22.1 #780

upgraded go version to 1.22.1 #780

unmarshall commented Apr 3, 2024

unmarshall commented Apr 3, 2024 •

edited

Loading

unmarshall commented Apr 3, 2024

aaronfern commented Apr 3, 2024

unmarshall commented Apr 3, 2024

unmarshall commented Apr 3, 2024 •

edited

Loading

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

ishan16696 commented Apr 5, 2024

ishan16696 left a comment

ishan16696 commented Apr 5, 2024

renormalize commented Apr 8, 2024

gardener-prow bot commented Apr 8, 2024

unmarshall commented Apr 11, 2024

unmarshall commented Apr 11, 2024

shreyas-s-rao commented Apr 14, 2024

upgraded go version to 1.22.1 #780

upgraded go version to 1.22.1 #780

Conversation

unmarshall commented Apr 3, 2024

unmarshall commented Apr 3, 2024 • edited Loading

unmarshall commented Apr 3, 2024

aaronfern commented Apr 3, 2024

unmarshall commented Apr 3, 2024

unmarshall commented Apr 3, 2024 • edited Loading

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

shreyas-s-rao commented Apr 3, 2024

ishan16696 commented Apr 5, 2024

ishan16696 left a comment

Choose a reason for hiding this comment

ishan16696 commented Apr 5, 2024

renormalize commented Apr 8, 2024

gardener-prow bot commented Apr 8, 2024

unmarshall commented Apr 11, 2024

unmarshall commented Apr 11, 2024

shreyas-s-rao commented Apr 14, 2024

unmarshall commented Apr 3, 2024 •

edited

Loading

unmarshall commented Apr 3, 2024 •

edited

Loading