Added unit tests. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amshuman-kr
suggested changes
Sep 27, 2019
ggaurav10
reviewed
Sep 30, 2019
georgekuruvillak
force-pushed
the
unit_tests
branch
from
88c3e72 to
fe42fdb
Compare
amshuman-kr
reviewed
Oct 9, 2019
| } | ||
| } | ||
| if err := r.addFinalizersToDependantSecrets(etcdCopy); err != nil { | ||
| if finalizers := sets.NewString(etcd.Finalizers...); !finalizers.Has(FinalizerName) { |
There was a problem hiding this comment.
Do we need the finalizers?
There was a problem hiding this comment.
Yes. We need it. It's recommended that we have finazliers on the resource being acted on. Basically without finalizer is somebody deletes the secret, etcd-backup-restore pod will fail continuously.
There was a problem hiding this comment.
without finalizer is somebody deletes the secret, etcd-backup-restore pod will fail continuously.
This is true for the secrets. But the finalizer above is for the etcd resource. Do we need that?
There was a problem hiding this comment.
Yes. Cause its definitely react on etcd resource. If etcd resource is deleted, then it has to do cleanup job like bring down the etcd sts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates unit tests for testing whether reconciliation occurs and it creates the resources mentioned in the charts.