chore: move Garden Cloud utils to own module #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
commented
Nov 17, 2023
| expect(getCloudDistributionName("https://backend.app.garden")).to.eql("Garden Cloud") | ||
| }) | ||
|
|
||
| // TODO: should we care about http/https here? Do we always get only https:// urls? |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we use the URL library to construct a URL from the string and just read the hostname so that we don't need to worry about the protocol.
It could just throw if the name isn't a valid hostname. It'd be a runtime error but we'd have runtime issues anyway if the hostname is bad.
vvagaytsev
changed the title
vvagaytsev
changed the title
eysi09
requested changes
Nov 17, 2023
| expect(getCloudDistributionName("https://backend.app.garden")).to.eql("Garden Cloud") | ||
| }) | ||
|
|
||
| // TODO: should we care about http/https here? Do we always get only https:// urls? |
There was a problem hiding this comment.
Can we use the URL library to construct a URL from the string and just read the hostname so that we don't need to worry about the protocol.
It could just throw if the name isn't a valid hostname. It'd be a runtime error but we'd have runtime issues anyway if the hostname is bad.
vvagaytsev
force-pushed
the
refactor/util-refactoring-2
branch
from
d0e32f5 to
ae0a261
Compare
eysi09
previously approved these changes
Nov 20, 2023
vvagaytsev
force-pushed
the
refactor/util-refactoring-2
branch
from
ae0a261 to
b0b5c69
Compare
eysi09
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is the continuation of the util-refactoring PR series started in #5431.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: