chore: restructuring util/util.ts (part 1)
#5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimBeyer
reviewed
Nov 17, 2023
| @@ -85,6 +83,10 @@ export type Unpacked<T> = T extends (infer U)[] | |||
| export type ExcludesFalsy = <T>(x: T | false | null | undefined) => x is T | |||
| export type MakeOptional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>> | |||
|
|
|||
| export interface Dictionary<T> { | |||
There was a problem hiding this comment.
Just a refactoring so definitely not a blocker, but I guess we could replace that with Record<string, T>?
There was a problem hiding this comment.
Good point. Maybe, this type was introduced as a short-handed type for string-keyed Record. In that case, we can just re-declare it as type Dictionary<T> = Record<string, T>
There was a problem hiding this comment.
This can be addressed in the next PR, there will be a series of PRs to refactor util/util.ts :)
TimBeyer
approved these changes
Nov 17, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the
util/util.tsfile is a big pile of helper functions of different kinds.This PR is the first step to decompose that utility module into smaller, semantically-scoped groups of helpers.
That decomposition will help to navigate the codebase more easily and allow us to deduplicate some helper functions and interfaces, making them more generic and unified.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: