Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(status): return more correct/granular statuses #491

Merged
merged 1 commit into from
Jan 31, 2019
Merged

fix(status): return more correct/granular statuses #491

merged 1 commit into from
Jan 31, 2019

Conversation

thsig
Copy link
Collaborator

@thsig thsig commented Jan 29, 2019 •
edited
Loading

Fixes #377.

Previously, deployed but unhealthy services would be reported as "ready" by the get status command. This is fixed here.

@edvald edvald self-assigned this Jan 29, 2019
@thsig thsig added this to the 0.9.1 milestone Jan 29, 2019
@thsig
fix(status): return more correct/granular statuses
d4a7cf2 
Fixes #377.

Previously, deployed but unhealthy services would be reported as "ready"
by the `get status` command. This is fixed here.
@thsig thsig force-pushed the container-status-fix branch from ce73323 to d4a7cf2 Compare January 30, 2019 13:44
@eysi09
Copy link
Collaborator

eysi09 commented Jan 31, 2019

Looks good:

  hello-container:
    ingresses:
      - path: /hello
        port: 80
        hostname: hello-world.local.app.garden
        protocol: http
    state: unhealthy

@eysi09 eysi09 merged commit abd6509 into master Jan 31, 2019
@eysi09 eysi09 deleted the container-status-fix branch January 31, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eysi09 eysi09 eysi09 approved these changes

Assignees

@edvald edvald

Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

getContainerServiceStatus returns state === ready even though pod is unhealthy
3 participants
@thsig @eysi09 @edvald