Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getContainerServiceStatus returns state === ready even though pod is unhealthy #377

Closed
eysi09 opened this issue Nov 16, 2018 · 0 comments · Fixed by #491
Closed

getContainerServiceStatus returns state === ready even though pod is unhealthy #377

eysi09 opened this issue Nov 16, 2018 · 0 comments · Fixed by #491
Assignees
@thsig
Labels
bug
Milestone
0.9.1

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Nov 16, 2018 •
edited
Loading

To reproduce:

  1. cd into simple-project
  2. open services/node-service/package.json
  3. change line 7 to "start": "node pain.js", (this breaks the start command)
  4. run garden deploy node-service
  5. notice that the deployment is successful, also that garden get status returns state: ready for the node-service, even though kubectl get pods --namespace=garden--default--simple-project shows that the status for the pod is CrashLoopBackOff
@eysi09 eysi09 changed the title getContainerServiceStatus returns "state === ready" even though pod is unhealthy getContainerServiceStatus returns state === ready even though pod is unhealthy Nov 16, 2018
@eysi09 eysi09 added the bug label Nov 18, 2018
@eysi09 eysi09 self-assigned this Nov 21, 2018
@eysi09 eysi09 added this to the 0.9.1 milestone Jan 28, 2019
@thsig thsig assigned thsig and unassigned eysi09 Jan 29, 2019
thsig added a commit that referenced this issue Jan 29, 2019
@thsig
fix(status): return more correct/granular statuses
ce73323 
Fixes #377.

Previously, deployed but unhealthy services would be reported as "ready"
by the `get status` command. This is fixed here.
@thsig thsig mentioned this issue Jan 29, 2019
Merged
thsig added a commit that referenced this issue Jan 30, 2019
@thsig
fix(status): return more correct/granular statuses
d4a7cf2 
Fixes #377.

Previously, deployed but unhealthy services would be reported as "ready"
by the `get status` command. This is fixed here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thsig thsig

Labels
bug
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

fix(status): return more correct/granular statuses garden-io/garden
2 participants
@thsig @eysi09