fix(k8s): regression in globs in k8s manifest files #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression was introduced in #4516. Initial implementation of glob patterns in files paths could result into empty list of files. This fixes the behaviour by fail-fast existence checks for manifest files.
Test coverage for `spec.files` of `Deploy` action of `kubernetes` type. * Add own Deployment manifest file, because builds are not executed in the test. * Add unit tests to document and cover the expected behaviour. Initial changes from c9efb47 did not have effect. The Deploy action `with-build-action` has never been called with `readManifests`.
thsig
previously requested changes
Jul 31, 2023
vvagaytsev
force-pushed
the
fix/regression-globs-in-k8s-manifest-files
branch
from
dad4395 to
18745e7
Compare
Walther
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The regression was introduced in #4516. After that PR, it was possible to silently skip all non-existing files specified in in
spec.filesof a Deploy action of typekubernetes.In
0.13.6that would fail with error like this:ENOENT: no such file or directory, open '~/garden/core/test/data/test-projects/kubernetes-type/with-build-action/deployment-action1.yaml'This PR implements some explicit checks for path existence and makes the output a bit more readable:
Invalid manifest file path(s) in Deploy action 'with-build-action'. Cannot find manifest file(s) at ~/garden/core/test/data/test-projects/kubernetes-type/.garden/build/exec-build/deployment-action1.yamlIssues #4505 and #4506 still exist. That's why the deployment can fail even with the existing manifest file. The build directory appears to be empty. It will be fixed in a separate PR.
Which issue(s) this PR fixes:
Fixes #4900
Special notes for your reviewer:
You can find more detail and explanation in the commit messages.