Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Print a warning or something if a kubernetes deploy action specifies files which are not found #4900

Closed
spenczar opened this issue Jul 30, 2023 · 0 comments · Fixed by #4903
Assignees
Labels
devex Developer experience and ease of use. feature request

Comments

@spenczar
Copy link

Feature Request

Background / Motivation

In #4899, I got pretty confused. I had a kubernetes deploy action which specified a file named jaeger-operator.yml. When I ran the deploy, nothing happened. That's because the file was actually named jaeger-oeprator.yaml - yaml vs yml.

What should the user be able to do?

Get warned when a file is specified that isn't actually found. Maybe throw an error and abort, even.

Why do they want to do this? What problem does it solve?

It's confusing for the tool to proceed happily even if a specified file is missing. It can lead to the false belief that a deploy succeeded.

Suggested Implementation(s)

Dunno! At least warning is good. A fatal error would make sense to me too, but maybe there's some reason to proceed? I don't really know.

How important is this feature for you/your team?

🌹 It’s a nice to have, but nice things are nice 🙂

@vvagaytsev vvagaytsev added the devex Developer experience and ease of use. label Jul 31, 2023
@vvagaytsev vvagaytsev self-assigned this Jul 31, 2023
@vvagaytsev vvagaytsev moved this to In Progress in Core Weekly Jul 31, 2023
@vvagaytsev vvagaytsev moved this from In Progress to Done in Core Weekly Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Developer experience and ease of use. feature request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants