Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): install microk8s addons sequentially #4865

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Jul 19, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4860

Special notes for your reviewer:

@vvagaytsev vvagaytsev requested a review from a team July 19, 2023 14:43
@vvagaytsev vvagaytsev force-pushed the fix/microk8s-addons branch from a47ab63 to 8618dbe Compare July 19, 2023 14:45
Copy link
Contributor

@shumailxyz shumailxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a minor nit.

.circleci/config.yml Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev force-pushed the fix/microk8s-addons branch from 8618dbe to 7aa2fdc Compare July 19, 2023 16:13
To avoid deprecation warning like this:

WARNING: Do not enable or disable multiple addons in one command.
This form of chained operations on addons will be DEPRECATED in the future.
Please, {action} one addon at a time: 'microk8s {action} <addon>'
@vvagaytsev
Copy link
Collaborator Author

This is ready for review now.

Copy link
Contributor

@Walther Walther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Let's hope the CI is a bit more stable now ✨

@vvagaytsev vvagaytsev merged commit 1a715f9 into main Jul 20, 2023
@vvagaytsev vvagaytsev deleted the fix/microk8s-addons branch July 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling multiple addons on MicroK8s in one invocation may lead to unreachable API server
3 participants