Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling multiple addons on MicroK8s in one invocation may lead to unreachable API server #4860

Closed
worldofgeese opened this issue Jul 19, 2023 · 4 comments · Fixed by #4865
Closed
Assignees
Labels
bug ci devex Developer experience and ease of use.

Comments

@worldofgeese
Copy link
Contributor

worldofgeese commented Jul 19, 2023

Bug

Current Behavior

When running microk8s enable addons dns storage registry ingress, a WARNING is printed:

            "WARNING: Do not enable or disable multiple addons in one command.\n"
            "         This form of chained operations on addons will be DEPRECATED in the future.\n"
            f"         Please, {action} one addon at a time: 'microk8s {action} <addon>'"

The responsible line of code is linked here.

Expected behavior

Garden should enable addons single invocation by single invocation.

Impacted code in our CircleCI config.yml and our config.ts.

Reproducible example

Use https://github.com/garden-io/quickstart-example

Workaround

Manually enable addons as user before running first garden deploy.

Additional context

Following garden deploy auto-enabling all addons on Windows 21H2, the MicroK8s API server became unreachable, requiring a complete VM delete and re-creation. I manually enabled the required addons one-by-one before running garden deploy again, at which point MicroK8s was accessible.

garden-microk8s-error-log.log

Your environment

  • OS: Windows Enterprise LTSC 21H2
  • How I'm running Kubernetes: MicroK8s

garden version 0.13.8

@worldofgeese worldofgeese changed the title Do not enable multiple MicroK8s in one invocation Enabling multiple addons on MicroK8s in one invocation may lead to unreachable API server Jul 19, 2023
@vvagaytsev vvagaytsev self-assigned this Jul 19, 2023
@vvagaytsev vvagaytsev moved this to In Progress in Core Weekly Jul 19, 2023
@vvagaytsev
Copy link
Collaborator

@worldofgeese, thanks for reporting this! It should be an easy-to-fix issue. I'm taking a look now.

By the way, the link to the config.ts points to the minikube-specific piece of code, not to the microk8s. So I think we should fix the function configureMicrok8sAddons.

Should we use sequential addon installation for minikube as well?

@vvagaytsev vvagaytsev added bug ci devex Developer experience and ease of use. labels Jul 19, 2023
@worldofgeese
Copy link
Contributor Author

By the way, the link to the config.ts points to the minikube-specific piece of code, not to the microk8s. So I think we should fix the function configureMicrok8sAddons.

Should we use sequential addon installation for minikube as well?

No, you're right, minikube doesn't suffer from this issue. I agree with you that it's the function configureMicrok8sAddons that needs love ❤️

@vvagaytsev
Copy link
Collaborator

Thanks @worldofgeese! Could you try this build, please?

@vvagaytsev vvagaytsev moved this from In Progress to Done in Core Weekly Jul 20, 2023
@vvagaytsev
Copy link
Collaborator

@worldofgeese the fix has been released in 0.13.9, please try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci devex Developer experience and ease of use.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants