fix: local-docker build failure when deploymentRegistry is enabled
#4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
changed the title
cwd on build status check in deploymentRegistry
vvagaytsev
changed the title
cwd on build status check in deploymentRegistrydeploymentRegistry is enabled
The action's build directory might not exist on the first build status check. The underlying docker command does not use the action's build directory in any context. The `cwd` for the `docker` command has been changed to the garden project root dir.
vvagaytsev
commented
Jul 14, 2023
| @@ -31,7 +31,7 @@ export const getLocalBuildStatus: BuildStatusHandler = async (params) => { | |||
| if (deploymentRegistry) { | |||
| const args = await getManifestInspectArgs(outputs.deploymentImageId, deploymentRegistry) | |||
| const res = await containerHelpers.dockerCli({ | |||
| cwd: action.getBuildPath(), | |||
| cwd: ctx.projectRoot, | |||
There was a problem hiding this comment.
We might need to ensure the existence of the action's build directory here. But it looks unnecessary at this step. Any comments/thoughts?
vvagaytsev
force-pushed
the
fix/local-docker-build-failure
branch
from
5825346 to
f470a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The issue (#4815) happens on the build status check when the active provider has the
deploymentRegistryconfiguration.The action's build directory might not exist on the first build status check.
The underlying
dockercommand does not use the action's build directory in any context. So, there is no reason to run thedockercommand from the action's build directory.The
cwdfor the underlyingdockercommand has been changed to the garden project root dir. Just like in a normal local status check inimageExistsLocally.Which issue(s) this PR fixes:
Fixes #4815
Special notes for your reviewer: