fix: local-docker build failure when deploymentRegistry is enabled (#…

…4835)

* chore: more informative error logging on `ENOENT`

* chore: remove old todo-comment

* fix(build): fix `cwd` when checking build status in deployment registry

The action's build directory might not exist on the first build status check.
The underlying docker command does not use the action's build directory in any context.
The `cwd` for the `docker` command has been changed to the garden project root dir.

core/src/build-staging/build-staging.ts

@@ -136,7 +136,6 @@ export class BuildStaging {
     this.createdPaths.clear()
   }
 
-  // TODO: ensure build path elsewhere?
   getBuildPath(config: BuildActionConfig<string, any> | ModuleConfig): string {
     // We don't stage the build for local exec modules, so the module path is effectively the build path.
     if (config.kind === "Module" && config.type === "exec" && config["local"] === true) {

core/src/plugins/kubernetes/container/build/local.ts

@@ -31,7 +31,7 @@ export const getLocalBuildStatus: BuildStatusHandler = async (params) => {
   if (deploymentRegistry) {
     const args = await getManifestInspectArgs(outputs.deploymentImageId, deploymentRegistry)
     const res = await containerHelpers.dockerCli({
-      cwd: action.getBuildPath(),
+      cwd: ctx.projectRoot,
       args,
       log,
       ctx,

core/src/util/util.ts

@@ -360,6 +360,7 @@ export function spawn(cmd: string, args: string[], opts: SpawnOpts = {}) {
       let msg = `An error occurred while trying to run '${cmd}' (${err.message}).`
       if ((<any>err).code === "ENOENT") {
         msg = `${msg} Please make sure '${cmd}' is installed and in the $PATH.`
+        cwd && (msg = `${msg} Please make sure '${cwd}' exists and is a valid directory path.`)
       }
       _reject(new RuntimeError({ message: msg, detail: { cmd, args, opts, result, err } }))
     })