Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): limit number of log lines that are fetched (#461) #483

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Jan 25, 2019

This is really just to prevent the browser from crashing on the user if the logs are huge. We still need better log support for the dashboard in general. E.g:

  • Improve UI
  • Fetch logs for individual services
  • Merge new log entries with those already in the data sore

@eysi09 eysi09 changed the base branch from dashboard-ui to master January 25, 2019 17:01
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a breaking change block in the commit message, for the CLI parameter change.
Going forward, it would be good to separate the small UI tweaks from the things that affect the logs command etc. in commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants