Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Only fetch last n log lines #461

Closed
eysi09 opened this issue Jan 13, 2019 · 0 comments
Closed

Dashboard: Only fetch last n log lines #461

eysi09 opened this issue Jan 13, 2019 · 0 comments
Assignees
Milestone

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Jan 13, 2019

Problem

Currently the dashboard fetches all logs for all services, which doesn't scale very well. The cli uses kubectl for getting logs that aren't tailed, in which case we can use --tail=n to get the last n lines. It doesn't look we can paginate the logs though.

Suggested solution

Decide on a max number of lines to fetch, say n, and divide by number of services, so that we get n/numServices log lines per service. When selecting a single service, fetch all n log lines for that service. Notify the user that they can use the CLI to tail logs for very large outputs.

@eysi09 eysi09 added this to the 0.9.0 milestone Jan 13, 2019
@eysi09 eysi09 self-assigned this Jan 13, 2019
@eysi09 eysi09 added bug and removed bug labels Jan 13, 2019
eysi09 added a commit that referenced this issue Jan 25, 2019
fix(dashboard): limit number of log lines that are fetched (#461)
@eysi09 eysi09 closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant