fix: respect spec.publishId for publishing image #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumailxyz
force-pushed
the
fix/respect-publishid
branch
from
5f54244 to
919b426
Compare
shumailxyz
force-pushed
the
fix/respect-publishid
branch
from
919b426 to
c60ff23
Compare
To fix the tests by avoiding calls to memoized methods inside the helper to be tested.
vvagaytsev
approved these changes
Jul 12, 2023
This was referenced May 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Respect the
spec.publishIdfor publishing the image usinggarden publish.Which issue(s) this PR fixes:
Fixes #4796
Special notes for your reviewer: