Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13: [Bug]: Publish does not adhere to specified publishId #5094

Closed
stefreak opened this issue Sep 15, 2023 · 1 comment · Fixed by #5585
Closed

0.13: [Bug]: Publish does not adhere to specified publishId #5094

stefreak opened this issue Sep 15, 2023 · 1 comment · Fixed by #5585

Comments

@stefreak
Copy link
Member

stefreak commented Sep 15, 2023

Garden Bonsai (0.13) Bug

Current Behavior

When running garden publish skopeo it does the following:

ℹ build.skopeo         → Tagging image with skopeo:v-8b7165e21a and gardendev/skopeo:v-8b7165e21a
ℹ build.skopeo         → Publishing image gardendev/skopeo:v-8b7165e21a...

(It ignores the tag specified in publishId)

Expected behavior

ℹ build.skopeo         → Tagging image with skopeo:v-8b7165e21a and gardendev/skopeo:1.41.0-3
ℹ build.skopeo         → Publishing image gardendev/skopeo:1.41.0-3...

Reproducible example

in the garden core images/skopeo/ directory

kind: Module
type: container
name: skopeo
description: Used by the kubernetes provider for interacting with container registries within a cluster
image: gardendev/skopeo:1.41.0-3
dockerfile: Dockerfile
extraFlags: [ "--platform", "linux/amd64" ]

or an equivalent build action like

kind: Build
type: container
name: skopeo
description: Used by the kubernetes provider for interacting with container registries within a cluster
spec:
  publishId: gardendev/skopeo:1.41.0-3
  dockerfile: Dockerfile
  extraFlags: [ "--platform", "linux/amd64" ]

Workaround

Specify the --tag option, then it correctly only publish the specified --tag:

 % garden publish skopeo --tag foobar
[...]
ℹ build.skopeo         → Tagging image with skopeo:v-8b7165e21a and gardendev/skopeo:foobar
ℹ build.skopeo         → Publishing image gardendev/skopeo:foobar...

Suggested solution(s)

Additional context

Your environment

  • OS: macOS
  • How I'm running Kubernetes: This is just Docker, no kubernetes involved

garden version 0.13.13

@stefreak
Copy link
Member Author

Super weird that we still have this issue as PR #4808 recently fixed an issue that sounds similar. We need test coverage for this.

CC @shumailxyz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants