-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix custom commands in dev mode #4650
Conversation
Just a nit on the commit message.
This will appear as "make a copy of projectRoots instead of using reference" in the list of bug fixes in the release notes. This sounds more like implementation details. We should consider using a brief summary addressing the issue as a commit header. And the details can go to the message body. Something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, rest looks solid. Good catch on the projectRoots
thing, that's a subtle one.
a76fd6e
to
9117243
Compare
replaces the old version artifacts with a version command artifact that is supported in dev mode and shown in help
Make a defensive copy of `projectRoots` instead of using a reference when memorizing old values before the reload.
9117243
to
d42e2b3
Compare
@vvagaytsev Thanks. Updated it to reflect improvement and combined both commits into one. Had to force push though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you! 🚀
@vvagaytsev Many thanks for pairing on this 🙌 |
What this PR does / why we need it:
version
command so it is supported in dev mode and shows up in help.Which issue(s) this PR fixes:
Fixes #4647
Special notes for your reviewer:
The second issue with custom gardenCommands reported in #4647 will be address separately. Tracking that with #4668