Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom commands broken in dev console #4647

Closed
jalper opened this issue Jun 15, 2023 · 1 comment · Fixed by #4650
Closed

custom commands broken in dev console #4647

jalper opened this issue Jun 15, 2023 · 1 comment · Fixed by #4650
Assignees

Comments

@jalper
Copy link
Contributor

jalper commented Jun 15, 2023

Bug

Current Behavior

Seeing two issues with custom commands in the dev console:

First, when you first enter the dev console, trying to run a custom command results in the following error:
Screenshot 2023-06-15 at 4 29 57 PM
Could not find command. Try typing help to see the available commands.

If you run something else built-in like help or deploy and then try the custom command, it will now work.

The second issue, however, is that some custom commands fail like this:
Screenshot 2023-06-15 at 4 36 03 PM
Missing cli argument in custom command wrapper. This is a bug. Please report it!

Both times I've seen this were on commands that use $concat: ${args.$rest} to allow args to be supplied to the custom command, but should work without any args.

Your environment

  • OS: macOS
    % garden version 0.13.2
@shumailxyz shumailxyz added the bug label Jun 16, 2023
@shumailxyz shumailxyz moved this to Todo in Core Weekly Jun 16, 2023
@shumailxyz shumailxyz moved this from Todo to Candidate in Core Weekly Jun 16, 2023
@shumailxyz shumailxyz self-assigned this Jun 16, 2023
@shumailxyz shumailxyz moved this from Candidate to Todo in Core Weekly Jun 16, 2023
@shumailxyz shumailxyz moved this from Todo to In Progress in Core Weekly Jun 16, 2023
@shumailxyz
Copy link
Contributor

The 2nd issue is that custom garden commands currently do not work at all in dev mode and result in that error. Tracking 2nd issue separately with #4668

@shumailxyz shumailxyz moved this from In Progress to Done in Core Weekly Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants