Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.13 fix: dev mode react state update on unmounted component #4221

Merged
merged 2 commits into from
May 10, 2023
Merged

0.13 fix: dev mode react state update on unmounted component #4221

merged 2 commits into from
May 10, 2023

Conversation

Orzelius
Copy link
Contributor

Orzelius added 2 commits May 10, 2023 19:22
@Orzelius
chore: remove unneeded lint ignore
768f881
@Orzelius
fix: properly unmount dev react FC
b035a90 
* don't unmount component on ctr-c
* cancel timeouts
* log final before unmount
vvagaytsev
vvagaytsev approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Orzelius Orzelius mentioned this pull request May 10, 2023
Closed
@Orzelius Orzelius merged commit b21d8ba into 0.13 May 10, 2023
@Orzelius Orzelius deleted the dev-mode-react-state branch May 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvagaytsev vvagaytsev vvagaytsev approved these changes

@Walther Walther Awaiting requested review from Walther

@shumailxyz shumailxyz Awaiting requested review from shumailxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orzelius @vvagaytsev