Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing exit does not kill the dev command for me #4209

Closed
thsig opened this issue May 9, 2023 · 7 comments
Closed

Typing exit does not kill the dev command for me #4209

thsig opened this issue May 9, 2023 · 7 comments
Assignees
@thsig

Comments

@thsig
Copy link
Collaborator

thsig commented May 9, 2023 •
edited
Loading

Reported by @eysi09.

"I get the outro messages but then command just hangs until I CTRL+C it."
@eysi09 eysi09 added this to 0.13 May 8, 2023
@thsig thsig converted this from a draft issue May 9, 2023
@thsig
Copy link
Collaborator Author

thsig commented May 9, 2023

@eysi09 I haven't been able to repro this one, does this happen reliably on your end or only under certain circumstances?

@eysi09
Copy link
Collaborator

eysi09 commented May 9, 2023

This happens every time.

I don't see any logs either, even at a silly level. It just hangs like this until I ctrl+c:

Screenshot 2023-05-09 at 12 54 20

Tested both on Kitty (my main terminal) and the default macOS terminal.

@thsig
Copy link
Collaborator Author

thsig commented May 10, 2023

Hmm, I see. I haven't been able to reproduce this on my end at all.

@Orzelius
Copy link
Contributor

I also fail to reproduce but this pr might fix it for you #4221

@thsig thsig self-assigned this May 10, 2023
@eysi09 eysi09 moved this from Todo to In Progress in 0.13 May 14, 2023
@eysi09 eysi09 mentioned this issue May 14, 2023
Merged
@thsig thsig moved this from In Progress to Done in 0.13 May 14, 2023
@thsig thsig moved this from Done to In Progress in 0.13 May 14, 2023
@thsig thsig moved this from In Progress to Done in 0.13 May 14, 2023
@eysi09 eysi09 moved this from Done to Todo in 0.13 May 14, 2023
@eysi09
Copy link
Collaborator

eysi09 commented May 14, 2023

I thought I had fixed this with #4262 but just noticed this again on my end.

Don't have a reliable repro at the moment but we need to investigate.

@vvagaytsev vvagaytsev moved this from Todo to In Progress in 0.13 May 15, 2023
@thsig thsig moved this from In Progress to Done in 0.13 May 17, 2023
@thsig thsig moved this from Done to In Progress in 0.13 May 17, 2023
@thsig
Copy link
Collaborator Author

thsig commented May 17, 2023

In the absence of a reliable repro, this should be a decent general-purpose safety measure:

767199c

@thsig thsig moved this from In Progress to Done in 0.13 May 17, 2023
@vvagaytsev
Copy link
Collaborator

Closing this an non-reproducible. Feel free to reopen if it still happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thsig thsig

Labels
None yet
Projects
No open projects
0.13
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thsig @eysi09 @vvagaytsev @Orzelius