Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add dependabot docker and npm ecosystems #3885

Merged
merged 2 commits into from
Mar 6, 2023
Merged

ci: add dependabot docker and npm ecosystems #3885

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f72b74
ci: add dependabot docker and npm ecosystems
stefreak Mar 3, 2023
e486923
ci(dependabot): comment out npm ecosystem
stefreak Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,21 @@

version: 2
updates:
# Maintain dependencies for GitHub Actions
# Automatically update GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
open-pull-requests-limit: 5
open-pull-requests-limit: 10
schedule:
interval: "weekly"
# Automatically update Dockerfile FROM images
- package-ecosystem: "docker"
directory: "/"
open-pull-requests-limit: 10
schedule:
interval: "daily"
# Automatically update NPM packages
- package-ecosystem: "npm"
directory: "/"
open-pull-requests-limit: 3 # for now, once 0.13 landed we can increase this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly hesitant on adding the npm updates right now, in part because of the earlier work on #3838 and discovering the need to configure our typescript project and its build process to support consuming ECMAScript Modules #3841. Currently, we are blocked by this on updating a lot of dependencies, we can't use "pure ESM build" dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have commented out the npm ecosystem for now and added a comment that mentions the #3841 ESM packaging issue

schedule:
interval: "daily"