feat(k8s): allow pulling base images when building in cluster #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
private-registry-auth
branch
10 times, most recently
from
45ff2be to
b7f0eb7
Compare
|
The current CI error appears related to #1373, so we should perhaps try and get that merged first. |
edvald
force-pushed
the
private-registry-auth
branch
from
b7f0eb7 to
92bdeb0
Compare
Flagging as a refactor because this is mainly intended for internal usage for now, since changing the namespace might have some unintended consequences.
edvald
force-pushed
the
private-registry-auth
branch
from
a87356f to
3cf6c35
Compare
eysi09
requested changes
Dec 5, 2019
docs/guides/in-cluster-building.md
Outdated
| @@ -143,16 +143,30 @@ your own cron jobs. | |||
|
|
|||
| ## Pulling base images from private registries | |||
|
|
|||
| Currently, only the _Local Docker_ build mode supports pulling base images from private registries in Dockerfiles. If you see an `ImagePullBackOff` error when using the other build modes, it's likely that it's failing because the Dockerfile for the module contains an entry like this: | |||
| The in-cluster builder may need to be able to pull base images from a private registry, e.g. if your Dockerfile starts something like this: | |||
There was a problem hiding this comment.
with missing in if your Dockerfile starts something...
We now use the configured `imagePullSecrets` on the `kubernetes` provider to authenticate the cluster Docker daemon or Kaniko pods, so that you can pull base images from private repositories. This PR includes new integration tests and some helpers that were needed to facilitate those. Closes #1236
edvald
force-pushed
the
private-registry-auth
branch
from
3cf6c35 to
e867903
Compare
eysi09
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We now use the configured
imagePullSecretson thekubernetesprovider to authenticate the cluster Docker daemon or Kaniko pods, so
that you can pull base images from private repositories.
This PR includes new integration tests and some helpers that were needed
to facilitate those.
Which issue(s) this PR fixes:
Closes #1236