fix(build): fix intermittent concurrency issues when staging build #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because both the BuildTask and GetServiceTask need to stage builds, they could in some cases end up stepping on each other because one doesn't depend on the other. I resolved that by adding a StageBuildTask that both depend on.
edvald
force-pushed
the
fix-build-stage
branch
from
94ea637 to
f705758
Compare
eysi09
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Because both the BuildTask and GetServiceTask need to stage builds,
they could in some cases end up stepping on each other because one
doesn't depend on the other. I resolved that by adding a StageBuildTask
that both depend on.
I also made DeleteService depend on a StageBuildTask to ensure that
sources are synced before attempting to run deleteService handlers,
which had caused a couple of reported issues.
Which issue(s) this PR fixes:
Fixes #1189
Fixed #1245