fix: resolve disabled action flag before duplicate action names validation
#6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/resolve-disabled-action-field
branch
from
adc9f6b to
7a174e6
Compare
vvagaytsev
changed the title
disabled action flag before duplicate action names validation
To emphasize that the fields store raw configs.
vvagaytsev
force-pushed
the
fix/resolve-disabled-action-field
branch
from
7a174e6 to
0705cad
Compare
vvagaytsev
force-pushed
the
fix/resolve-disabled-action-field
branch
from
9b962f6 to
ddb96f6
Compare
vvagaytsev
force-pushed
the
fix/resolve-disabled-action-field
branch
from
1d38d1d to
383c361
Compare
vvagaytsev
force-pushed
the
fix/resolve-disabled-action-field
branch
from
383c361 to
8582afc
Compare
stefreak
approved these changes
Jul 17, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR patches the feature implemented in #4805 and #5686.
Which issue(s) this PR fixes:
Without this fix, the disabled flag on actions is not resolved properly if it's defined as a template string.
Special notes for your reviewer: