fix(template): use stricter context for disabled flag resolution
#6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow `this.*` context for `disabled` field. To avoid unnecessary complexity in passing action mode to the `scanAndAddConfigs()`.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not allow
this.*context fordisabledfield, just to avoid unnecessary complexity in passing action mode to thescanAndAddConfigs().Now an error is thrown if
disabled:flag has a reference to${this.mode}.Which issue(s) this PR fixes:
Fixes the incorrectly defined action mode introduced in #6293.
Special notes for your reviewer:
We can support
${this.*}context as a separate feature PR if necessary.