Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add environments field on actions #5686

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Jan 31, 2024

This allows setting e.g. environments: [dev] on actions instead of the
more verbose disabled: ${environment.name != "dev"}.

Resolves #3221

@edvald edvald requested a review from vvagaytsev January 31, 2024 18:16
vvagaytsev
vvagaytsev previously approved these changes Feb 1, 2024
@vvagaytsev vvagaytsev added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@stefreak
Copy link
Member

stefreak commented Feb 1, 2024

Added a note that this resolves #3221

stefreak
stefreak previously approved these changes Feb 1, 2024
@eysi09
Copy link
Collaborator

eysi09 commented Feb 3, 2024

@edvald, looks like the docs need to be updated.

This allows setting e.g. `environments: [dev]` on actions instead of the
more verbose `disabled: ${environment.name != "dev"}`.
@vvagaytsev vvagaytsev dismissed stale reviews from stefreak and themself via 45b8ad7 February 8, 2024 12:26
@vvagaytsev vvagaytsev requested a review from stefreak February 8, 2024 12:26
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the branch to resolve the conflicts. Looks like the docs were up-to-date. That was likely a flaky failure for the dead links.

@vvagaytsev vvagaytsev added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit a7bcf8c Feb 8, 2024
44 checks passed
@vvagaytsev vvagaytsev deleted the environments-field branch February 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: avoid double negation by introducing enabled: for modules
4 participants