Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service dependencies are not included in auto-reload dependants #108

Closed
edvald opened this issue May 24, 2018 · 0 comments
Closed

Service dependencies are not included in auto-reload dependants #108

edvald opened this issue May 24, 2018 · 0 comments
Assignees
@thsig
Labels
bug

Comments

@edvald
Copy link
Collaborator

edvald commented May 24, 2018

src/watch.ts:computeAutoReloadDependants() currently only deals with module build dependencies. It should be extended to include the modules of service dependencies. Might need to consider #107 along the way (not exactly sure if it applies but I suspect it does).
@edvald edvald added the bug label May 24, 2018
@thsig thsig self-assigned this May 24, 2018
thsig added a commit that referenced this issue May 24, 2018
@thsig
fix: #107 & #108 - incl. deps in auto-reload.
5135329 
When specifying which modules to watch, modules for their build &
service dependencies are now also watched.

Additionally, service dependencies are now included as auto reload
dependants.

Unit tests coming soon, will be squashed to this commit.
thsig added a commit that referenced this issue May 25, 2018
@thsig
fix: #107 & #108 - incl. deps in auto-reload.
d1aaf5e 
When specifying which modules to watch, modules for their build &
service dependencies are now also watched.

Additionally, service dependencies are now included as auto reload
dependants.
thsig added a commit that referenced this issue May 25, 2018
@thsig
Merge pull request #112 from garden-io/auto-reload-dep-fix
95368cc 
fix: #107 & #108 - incl. deps in auto-reload.
@thsig thsig closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thsig thsig

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edvald @thsig