Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module watcher should also watch build dependencies #107

Closed
edvald opened this issue May 23, 2018 · 0 comments
Closed

Module watcher should also watch build dependencies #107

edvald opened this issue May 23, 2018 · 0 comments
Assignees
@thsig
Labels
bug

Comments

@edvald
Copy link
Collaborator

edvald commented May 23, 2018

Currently when build dependencies that are not explicitly being watched are modified, we don't trigger execution. For example, when I run garden deploy module-a -w and module-b is a build dependency, nothing happens when we modify module-b. Should be fairly easy to fix.
@edvald edvald added the bug label May 23, 2018
@thsig thsig self-assigned this May 24, 2018
@edvald edvald mentioned this issue May 24, 2018
Closed
thsig added a commit that referenced this issue May 24, 2018
@thsig
fix: #107 & #108 - incl. deps in auto-reload.
5135329 
When specifying which modules to watch, modules for their build &
service dependencies are now also watched.

Additionally, service dependencies are now included as auto reload
dependants.

Unit tests coming soon, will be squashed to this commit.
@thsig thsig closed this as completed in d1aaf5e May 25, 2018
thsig added a commit that referenced this issue May 25, 2018
@thsig
Merge pull request #112 from garden-io/auto-reload-dep-fix
95368cc 
fix: #107 & #108 - incl. deps in auto-reload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thsig thsig

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edvald @thsig