Skip to content

Commit

Permalink
chore: remove unnecessary code and comments
Browse files Browse the repository at this point in the history
Local mode checks were moved to `getForwardablePorts` in #5022.
  • Loading branch information
vvagaytsev committed Sep 13, 2023
1 parent 668a246 commit 59d0ef3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
1 change: 0 additions & 1 deletion core/src/plugins/kubernetes/helm/deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ export const helmDeploy: DeployActionHandler<"deploy", HelmDeployAction> = async
timeoutSec: timeout,
})

// Local mode has its own port-forwarding configuration
const forwardablePorts = getForwardablePorts({ resources: manifests, parentAction: action, mode })

// Make sure port forwards work after redeployment
Expand Down
11 changes: 4 additions & 7 deletions core/src/plugins/kubernetes/kubernetes-type/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,10 @@ export const getKubernetesDeployStatus: DeployActionHandler<"getStatus", Kuberne
}
}

// Note: Local mode has its own port-forwarding configuration
if (deployedMode !== "local") {
try {
forwardablePorts = getForwardablePorts({ resources: remoteResources, parentAction: action, mode: deployedMode })
} catch (error) {
log.debug({ msg: `Unable to extract forwardable ports: ${error.message}`, error })
}
try {
forwardablePorts = getForwardablePorts({ resources: remoteResources, parentAction: action, mode: deployedMode })
} catch (error) {
log.debug({ msg: `Unable to extract forwardable ports: ${error.message}`, error })
}

return composeKubernetesDeployStatus({
Expand Down

0 comments on commit 59d0ef3

Please sign in to comment.