refactor: move input args check into getForwardablePorts

garden-io · Sep 13, 2023 · 668a246 · 668a246
1 parent 50cd2f1
commit 668a246
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/core/src/plugins/kubernetes/kubernetes-type/handlers.ts b/core/src/plugins/kubernetes/kubernetes-type/handlers.ts
@@ -300,7 +300,7 @@ export const getKubernetesDeployStatus: DeployActionHandler<"getStatus", Kuberne
   }
 
   // Note: Local mode has its own port-forwarding configuration
-  if (deployedMode !== "local" && remoteResources && remoteResources.length > 0) {
+  if (deployedMode !== "local") {
     try {
       forwardablePorts = getForwardablePorts({ resources: remoteResources, parentAction: action, mode: deployedMode })
     } catch (error) {

diff --git a/core/src/plugins/kubernetes/port-forward.ts b/core/src/plugins/kubernetes/port-forward.ts
@@ -228,6 +228,10 @@ export function getForwardablePorts({
   parentAction: Resolved<KubernetesDeployAction | HelmDeployAction> | undefined
   mode: ActionMode
 }): ForwardablePort[] {
+  if (resources.length === 0) {
+    return []
+  }
+
   const spec = parentAction?.getSpec()
 
   // Note: Local mode has its own port-forwarding configuration