Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phyloseq bar chart #6575

Merged
merged 15 commits into from
Dec 3, 2024
Merged

add phyloseq bar chart #6575

merged 15 commits into from
Dec 3, 2024

Conversation

MaraBesemer
Copy link
Contributor

@MaraBesemer MaraBesemer commented Nov 19, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you plese fix the Rscript linting? Thanks

@bgruening
Copy link
Member

I think we are using this script https://github.com/galaxyproject/tools-iuc/blob/main/.github/styler.R

@bgruening
Copy link
Member

Linting passed but now your good test are falling.

Job in error state.. tool_id: phyloseq_plot_bar, exit_code: 1, stderr: Error in readRDS(opt$input) : bad 'file' argument
Execution halted

@paulzierep
Copy link
Contributor

Fix: MaraBesemer#1
Could you maybe add one or two more test, that check for empty parameter input and different parameters ?

@bgruening bgruening merged commit 10dfb13 into galaxyproject:main Dec 3, 2024
14 checks passed
@bgruening
Copy link
Member

Thanks @MaraBesemer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants